[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for R
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU |
Date: |
Fri, 9 Mar 2018 05:37:18 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2912d721ce membarrier: add --enable-membarrier
5f0f5753cc membarrier: introduce qemu/sys_membarrier.h
8acb0ecf90 rcu: make memory barriers more explicit
7c506b9d5d rcutorture: remove synchronize_rcu from readers
=== OUTPUT BEGIN ===
Checking PATCH 1/4: rcutorture: remove synchronize_rcu from readers...
Checking PATCH 2/4: rcu: make memory barriers more explicit...
Checking PATCH 3/4: membarrier: introduce qemu/sys_membarrier.h...
ERROR: memory barrier without comment
#70: FILE: include/qemu/sys_membarrier.h:14:
+#define smp_mb_global() smp_mb()
ERROR: memory barrier without comment
#71: FILE: include/qemu/sys_membarrier.h:15:
+#define smp_mb_placeholder() smp_mb()
total: 2 errors, 0 warnings, 77 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: membarrier: add --enable-membarrier...
WARNING: line over 80 characters
#190: FILE: util/sys_membarrier.c:45:
+ error_report("This QEMU binary requires MEMBARRIER_CMD_SHARED
support.");
total: 0 errors, 1 warnings, 152 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU, Paolo Bonzini, 2018/03/09
- [Qemu-devel] [PATCH 4/4] membarrier: add --enable-membarrier, Paolo Bonzini, 2018/03/09
- [Qemu-devel] [PATCH 2/4] rcu: make memory barriers more explicit, Paolo Bonzini, 2018/03/09
- [Qemu-devel] [PATCH 3/4] membarrier: introduce qemu/sys_membarrier.h, Paolo Bonzini, 2018/03/09
- [Qemu-devel] [PATCH 1/4] rcutorture: remove synchronize_rcu from readers, Paolo Bonzini, 2018/03/09
- Re: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU,
no-reply <=
- Re: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU, Emilio G. Cota, 2018/03/21