[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS |
Date: |
Fri, 9 Mar 2018 14:58:47 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Peter Lieven (address@hidden) wrote:
> this actually limits (as the original commit mesage suggests) the
> number of I/O buffers that can be allocated and not the number
> of parallel (inflight) I/O requests.
>
> Signed-off-by: Peter Lieven <address@hidden>
I've queued 1-3 (which have Juan's R-b).
Dave
> ---
> migration/block.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/migration/block.c b/migration/block.c
> index 87bb35c..41b95d1 100644
> --- a/migration/block.c
> +++ b/migration/block.c
> @@ -36,7 +36,7 @@
>
> #define MAX_IS_ALLOCATED_SEARCH (65536 * BDRV_SECTOR_SIZE)
>
> -#define MAX_INFLIGHT_IO 512
> +#define MAX_IO_BUFFERS 512
>
> //#define DEBUG_BLK_MIGRATION
>
> @@ -775,9 +775,8 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
> while ((block_mig_state.submitted +
> block_mig_state.read_done) * BLOCK_SIZE <
> qemu_file_get_rate_limit(f) &&
> - (block_mig_state.submitted +
> - block_mig_state.read_done) <
> - MAX_INFLIGHT_IO) {
> + (block_mig_state.submitted + block_mig_state.read_done) <
> + MAX_IO_BUFFERS) {
> blk_mig_unlock();
> if (block_mig_state.bulk_completed == 0) {
> /* first finish the bulk phase */
> --
> 2.7.4
>
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/5] block migration fixes, Peter Lieven, 2018/03/08
- [Qemu-devel] [PATCH 5/5] migration/block: compare only read blocks against the rate limiter, Peter Lieven, 2018/03/08
- [Qemu-devel] [PATCH 4/5] migration/block: limit the number of parallel I/O requests, Peter Lieven, 2018/03/08
- [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS, Peter Lieven, 2018/03/08
- [Qemu-devel] [PATCH 2/5] migration/block: reset dirty bitmap before read in bulk phase, Peter Lieven, 2018/03/08
- [Qemu-devel] [PATCH 1/5] migration: do not transfer ram during bulk storage migration, Peter Lieven, 2018/03/08