[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snap
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case |
Date: |
Fri, 9 Mar 2018 10:08:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote:
This test case adds an NBD server export and then invokes
blockdev-snapshot-sync, which changes the BlockDriverState node that the
Do we want to test 'blockdev-snapshot' instead (or in addition), given
the subthread discussion about blockdev-snapshot-sync being the older
non-preferred form?
NBD server's BlockBackend points to. This is an interesting scenario to
test and exercises the code path fixed by the previous commit.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/qemu-iotests/208 | 55 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/208.out | 9 ++++++++
tests/qemu-iotests/group | 1 +
3 files changed, 65 insertions(+)
create mode 100755 tests/qemu-iotests/208
create mode 100644 tests/qemu-iotests/208.out
Switching the order of the two patches in this series makes it obvious
that this patch does tickle the code path in question, so you definitely
get:
Tested-by: Eric Blake <address@hidden>
And unless answering the question about blockdev-snapshot causes you to
change things for more/different QMP commands, I'm also fine with:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: let blk_add/remove_aio_context_notifier() tolerate BDS changes, (continued)
- [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefan Hajnoczi, 2018/03/06
- Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefano Panella, 2018/03/06
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefan Hajnoczi, 2018/03/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefano Panella, 2018/03/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefan Hajnoczi, 2018/03/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Stefano Panella, 2018/03/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Max Reitz, 2018/03/07
- Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Max Reitz, 2018/03/07
Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case,
Eric Blake <=
Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case, Max Reitz, 2018/03/12
Re: [Qemu-devel] [PATCH 0/2] block: fix nbd-server-stop crash after blockdev-snapshot-sync, Eric Blake, 2018/03/07