Re: [Qemu-devel] [PATCH v8 11/23] monitor: introduce monitor_qmp_respond()

[Eric Blake]

On 03/09/2018 02:59 AM, Peter Xu wrote:
> A tiny refactoring, preparing to split the QMP dispatcher away.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
>   monitor.c | 50 +++++++++++++++++++++++++++++++++-----------------
>   1 file changed, 33 insertions(+), 17 deletions(-)

> +    if (rsp) {
> +        if (id) {
> +            /* This is for the qdict below. */
> +            qobject_incref(id);
> +            qdict_put_obj(qobject_to_qdict(rsp), "id", id);

Another victim of qobject_to() refactoring.

Fixing that is minor, so
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org