qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to s


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump
Date: Sat, 10 Mar 2018 21:05:47 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/05/2018 10:37 AM, Thomas Huth wrote:
QEMU's screendump command can only take dumps from the primary display.
When using multiple VGA cards, there is no way to get a dump from a
secondary card or other display heads yet. So let's add an 'device' and
a 'head' parameter to the HMP and QMP commands to be able to specify
alternative devices and heads with the screendump command, too.

Reviewed-by: Daniel P. Berrangé <address@hidden>
Acked-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
  v4:
  - Improved the documentation of the parameters in ui.json a little bit
    (according to the suggestions from Eric)

We're getting close to soft freeze; I'll include this in my QAPI tree, since I have an upcoming pull request, rather than figuring out if Gerd is also doing one more pull (but of course, if he does, it doesn't hurt; git handles patches on multiple merge branches just fine, or I can rebase it out of mine if Gerd's tree goes in first).

Queued:

git://repo.or.cz/qemu/ericb.git qapi
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]