[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via defaul
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/ |
|
Date: |
Mon, 12 Mar 2018 11:05:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 12.03.2018 10:53, Paolo Bonzini wrote:
> On 12/03/2018 10:48, Thomas Huth wrote:
>>> +obj-$(CONFIG_VTD) += x86-iommu.o intel_iommu.o
>>> +obj-$(CONFIG_AMD_IOMMU) += x86-iommu.o amd_iommu.o
>> The linker likely does not care if x86-iommu.o is included twice
>
> The linker actually cares, but rules.mak drops the duplicate:
>
> commit e2a99ad3e174ab4c9d2320dcecd779230409829f
> Author: Stefan Hajnoczi <address@hidden>
> Date: Thu Aug 25 09:18:52 2011 +0100
>
> build: sort objects to remove duplicates for link
Ah, nice, I wasn't aware of that trick. The current patch looks fine to
me in this case:
Reviewed-by: Thomas Huth <address@hidden>