qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] BiteSizedTasks: API conversion


From: Su Hang
Subject: [Qemu-devel] BiteSizedTasks: API conversion
Date: Mon, 12 Mar 2018 19:24:07 +0800 (GMT+08:00)

Dear Thomas,
I'm tring to work on this job:
BiteSizedTasks:
    API conversion:
        Replace calls to functions named cpu_physical_memory_* with 
address_space_*.
When I try to replace
`cpu_physical_memory_write_rom(rom->as, rom->addr, rom->data, rom->datasize);`
with
`address_space_write_rom(rom->as, rom->addr, rom->data, rom->datasize);`
gcc complains about:
"""
/home/darcy/workstation/qemu/hw/core/loader.c: In function ‘rom_reset’:
/home/darcy/workstation/qemu/hw/core/loader.c:1098:12: error: implicit 
declaration of function ‘address_space_write_rom’ 
[-Werror=implicit-function-declaration]
            address_space_write_rom(rom->as, rom->addr, rom->data,
            ^
/home/darcy/workstation/qemu/hw/core/loader.c:1098:12: error: nested extern 
declaration of ‘address_space_write_rom’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
/home/darcy/workstation/qemu/rules.mak:66: recipe for target 'hw/core/loader.o' 
failed
make: *** [hw/core/loader.o] Error 1
"""

Then I use `ag address_space_write_rom` in qemu's root directory,
it failed to find any function named `address_space_write_rom`.

By the way, sorry I don't find tool like `WikiBlame`, to help me find
who add this task. So I can't CC others but you.

Best,
Su Hang

reply via email to

[Prev in Thread] Current Thread [Next in Thread]