[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic() |
|
Date: |
Mon, 12 Mar 2018 11:48:01 +0000 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Fri, Mar 09, 2018 at 06:27:09PM +0100, Kevin Wolf wrote:
> Everything that refers to the protocol layer or QemuOpts is moved out of
> block_crypto_create_generic(), so that the remaining function is
> suitable to be called by a .bdrv_co_create implementation.
>
> LUKS is the only driver that actually implements the old interface, and
> we don't intend to use it in any new drivers, so put the moved out code
> directly into a LUKS function rather than creating a generic
> intermediate one.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/crypto.c | 95
> +++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 61 insertions(+), 34 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|