Re: [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

[Daniel P . Berrangé]

On Tue, Feb 06, 2018 at 08:48:43AM -0600, Eric Blake wrote:
> On 02/06/2018 03:13 AM, Daniel P. Berrangé wrote:
> 
> > > > +++ b/qapi/sockets.json
> > > > @@ -123,6 +123,13 @@
> > > >    #
> > > >    # @unix:  Unix domain socket
> > > >    #
> > > > +# @vsock: VMCI address
> > > > +#
> > > > +# @fd: decimal is for file descriptor number, otherwise a file 
> > > > descriptor name.
> > > > +#      Named file descriptors are permitted in monitor commands, in 
> > > > combination
> > > > +#      with the 'getfd' command. Decimal file descriptors are 
> > > > permitted at
> > > > +#      startup or other contexts where no monitor context is active.
> > > > +#
> > > >    # Since: 2.9
> > > 
> > > There doesn't seem to be any way to introspect if we support decimal fds
> > > from the command line; is that going to be a problem?
> > 
> > Libvirt needs to know when it can use it, so any suggestions ?
> 
> Patch 9/9 modified qemu_chardev_opts; does that change reflect through
> query-command-line-options?  Not all QemuOpts changes are introspectible
> yet, and Markus has been trying to tackle that, but if this particular one
> works, we can use that as our witness (after all, if I understand correctly,
> the new feature you are adding here is NOT affecting the QMP usage, but is
> an enhancement for command-line usage).

Yeah, 'fd' does appear there, so that's good enough for now.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|