Re: [Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

[Eric Blake]

On 03/12/2018 08:14 AM, Daniel P. Berrangé wrote:
> On Mon, Mar 12, 2018 at 08:12:44AM -0500, Eric Blake wrote:
> > On 03/12/2018 07:49 AM, Daniel P. Berrangé wrote:
> > > An update of:
> > >
> > >     v1: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04618.html
> > >     v2: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04706.html
> > >     v3: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04892.html
> > >     v4: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg00950.html
> > >
> > > This enables fixing a long standing problem that libvirt has with
> > > starting up QEMU. It has to busy-wait retrying connect() on the QMP
> > > monitor socket until QEMU finally creates & listens on it, but at same
> > > time must be careful to not wait forever if QEMU exits.
> > >
> > > With this patch series, libvirt can simply pass in a pre-opened UNIX domain
> > > socket file descriptor, which it can immediately connect to with no busy-wait.

> > Whose tree should this go through?  It's got some QAPI impact, so I'm okay
> > including it in my QAPI pull request later today, if there is no better
> > tree...
>
> These days I usually send PR for stuff touching sockets code myself. So
> unless someone else strongly prefers to take it via their tree for sake
> of any easy of conflict / merge resolution, I can do a PR once acked.

Okay, I'll go through one more round of reviews, then let you send the 
PR; we still have time to make softfreeze tomorrow.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org