Re: [Qemu-devel] [PATCH v2] 9p: Convert use of atoi to qemu_strtoi to allow error checking

[Eric Blake]

On 03/12/2018 10:33 AM, Nia Alarie wrote:
> Signed-off-by: Nia Alarie <address@hidden>
> ---
>   hw/9pfs/9p.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)

Helping out our CI tools:
Based-on: <address@hidden>

> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 48fa48e720..254385dfa4 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -15,6 +15,7 @@
>   #include <glib/gprintf.h>
>   #include "hw/virtio/virtio.h"
>   #include "qapi/error.h"
> +#include "qemu/cutils.h"
>   #include "qemu/error-report.h"
>   #include "qemu/iov.h"
>   #include "qemu/sockets.h"
> @@ -2213,8 +2214,14 @@ static void coroutine_fn v9fs_create(void *opaque)
>           }
>           v9fs_path_copy(&fidp->path, &path);
>       } else if (perm & P9_STAT_MODE_LINK) {
> -        int32_t ofid = atoi(extension.data);
> -        V9fsFidState *ofidp = get_fid(pdu, ofid);
> +        int ofid;

'unsigned int' and...

> +        V9fsFidState *ofidp;
> +
> +        if (qemu_strtoi(extension.data, NULL, 10, &ofid)) {

qemu_strtoui() might be smarter, per Greg's comments on v1.

> +            err = -EINVAL;
> +            goto out;
> +        }
> +        ofidp = get_fid(pdu, (int32_t)ofid);

This cast is spurious.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org