Re: [Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
11a2d24854 char: allow passing pre-opened socket file descriptor at startup
38d7ed855a char: refactor parsing of socket address information
dacc6f8ebe sockets: allow SocketAddress 'fd' to reference numeric file 
descriptors
8d91d776c7 sockets: check that the named file descriptor is a socket
4ac9d04d7b sockets: move fd_is_socket() into common sockets code
179118052a sockets: strengthen test suite IP protocol availability checks
357edea8d3 sockets: pull code for testing IP availability out of specific test
7fca025ea8 cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int 
types
68d51518fb char: don't silently skip tn3270 protocol init when TLS is enabled

=== OUTPUT BEGIN ===
Checking PATCH 1/9: char: don't silently skip tn3270 protocol init when TLS is 
enabled...
Checking PATCH 2/9: cutils: add qemu_strtoi & qemu_strtoui parsers for 
int/unsigned int types...
ERROR: consider using qemu_strtol in preference to strtol
#753: FILE: util/cutils.c:338:
+    lresult = strtol(nptr, &ep, base);

ERROR: consider using qemu_strtoul in preference to strtoul
#805: FILE: util/cutils.c:390:
+    lresult = strtoul(nptr, &ep, base);

total: 2 errors, 0 warnings, 793 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/9: sockets: pull code for testing IP availability out of 
specific test...
Checking PATCH 4/9: sockets: strengthen test suite IP protocol availability 
checks...
Checking PATCH 5/9: sockets: move fd_is_socket() into common sockets code...
Checking PATCH 6/9: sockets: check that the named file descriptor is a socket...
Checking PATCH 7/9: sockets: allow SocketAddress 'fd' to reference numeric file 
descriptors...
Checking PATCH 8/9: char: refactor parsing of socket address information...
Checking PATCH 9/9: char: allow passing pre-opened socket file descriptor at 
startup...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden