Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

[Eric Blake]

On 03/12/2018 09:06 PM, address@hidden wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Type: series
> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

>    CC      block/nbd-client.o
>    CC      block/sheepdog.o
> /var/tmp/patchew-tester-tmp-erqpie2w/src/block/nbd-client.c: In function 
> ‘nbd_client_co_block_status’:
> /var/tmp/patchew-tester-tmp-erqpie2w/src/block/nbd-client.c:890:15: error: 
> ‘extent.flags’ may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>       NBDExtent extent;
>                 ^~~~~~
> /var/tmp/patchew-tester-tmp-erqpie2w/src/block/nbd-client.c:925:19: error: 
> ‘extent.length’ may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>       *pnum = extent.length;
>               ~~~~~~^~~~~~~

May be a false positive where the compiler merely can't see through the 
logic, or it might be a real bug; but I suspect either way that the 
solution is to initialize this (I'm guessing patch 5), as in:

NBDExtent extent = { 0 };

Will squash that in when I get to that part of the review.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org