[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking "rom-size" |
|
Date: |
Tue, 13 Mar 2018 11:59:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/12/2018 10:42 PM, Wolfram Sang wrote:
> The value for "rom-size" is used as a divisor, so it must not be 0 or it
> will segfault. A size of 0 wouldn't make sense as well.
>
> Signed-off-by: Wolfram Sang <address@hidden>
> ---
> hw/nvram/eeprom_at24c.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
> index 8507516b7e..d82710e1df 100644
> --- a/hw/nvram/eeprom_at24c.c
> +++ b/hw/nvram/eeprom_at24c.c
> @@ -120,6 +120,11 @@ int at24c_eeprom_init(I2CSlave *i2c)
> {
> EEPROMState *ee = AT24C_EE(i2c);
>
> + if (!ee->rsize) {
> + ERR("rom-size not allowed to be 0\n");
This might be more useful:
error_report("Minimum rom-size is %u", AT24C_ROMSIZE_MIN);
> + exit(1);
> + }
> +
> ee->mem = g_malloc0(ee->rsize);
>
> if (ee->blk) {
>