[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper e
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file |
Date: |
Tue, 13 Mar 2018 16:11:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 08/03/2018 20:03, Ian Jackson wrote:
> If you pass scripts/get_maintainer.pl the name of a FIFO or other
> exciting object (/dev/stdin, for example), it would falsely print
> "file not found". Instead: stat the object rather than using -f so
> that we do not mind if the object is not a file; and print the errno
> value in the error message.
>
> Signed-off-by: Ian Jackson <address@hidden>
> CC: Thomas Huth <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefano Stabellini <address@hidden>
> CC: Anthony PERARD <address@hidden>
> ---
> v6: New patch in this version of the series
> ---
> scripts/get_maintainer.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 07369aa..43fb5f5 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -381,8 +381,8 @@ foreach my $file (@ARGV) {
> ##if $file is a directory and it lacks a trailing slash, add one
> if ((-d $file)) {
> $file =~ s@([^/])address@hidden/@;
> - } elsif (!(-f $file)) {
> - die "$P: file '${file}' not found\n";
> + } elsif (!(stat $file)) {
> + die "$P: file '${file}' not found: $!\n";
> }
> }
> if ($from_filename) {
>
Queued, thanks.
Paolo
- [Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, (continued)
- [Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/12] xen: link against xentoolcore, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements, Ian Jackson, 2018/03/09