Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

[Eric Blake]

On 03/12/2018 11:49 PM, Alexey Kardashevskiy wrote:
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>
> checkpatch.pl complains on every single changed line as it keeps
> using tabs - do I need to post 's/\t/    /g'?

No. checkpatch.pl is guidance, but even stronger is 'be consistent to 
what you are editing'; we know to ignore the checkpatch warnings on 
slirp code as that has historically used tabs.  Mixed style, where TABS 
occur in the context but your new additions use space, is also okay. 
(You CAN clean up the entire slirp files if you want, but get maintainer 
buy-in before doing so; and make the indentation cleanup separate from 
any other patch, so that a diff with whitespace ignored shows no change).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org