[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] docker: fedora: test more components
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] docker: fedora: test more components |
|
Date: |
Thu, 15 Mar 2018 15:31:28 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/13/2018 01:33 PM, Fam Zheng wrote:
> On Tue, 03/13 13:05, Paolo Bonzini wrote:
>> Install optional dependencies of QEMU to get better coverage.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> tests/docker/dockerfiles/fedora.docker | 13 ++++++++++---
>> 1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/docker/dockerfiles/fedora.docker
>> b/tests/docker/dockerfiles/fedora.docker
>> index 994a35a..0d9da45 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -1,9 +1,16 @@
>> FROM fedora:27
>> ENV PACKAGES \
>> ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname \
>> - glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>> - gcc gcc-c++ clang make perl which bc findutils libaio-devel \
>> - nettle-devel libasan libubsan \
>> + gcc gcc-c++ clang make perl which bc findutils glib2-devel \
>> + libaio-devel pixman-devel zlib-devel libfdt-devel libasan libubsan \
>> + bluez-libs-devel brlapi-devel bzip2-devel \
>> + device-mapper-multipath-devel glusterfs-api-devel gnutls-devel \
>> + gtk3-devel libattr-devel libcap-devel libcap-ng-devel libcurl-devel \
>> + libjpeg-devel libpng-devel librbd-devel libssh2-devel libusbx-devel \
>> + libxml2-devel lzo-devel ncurses-devel nettle-devel nss-devel \
>> + numactl-devel SDL2-devel snappy-devel spice-server-devel \
>> + systemtap-sdt-devel usbredir-devel virglrenderer-devel vte3-devel \
>> + xen-devel \
>> mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config
>> \
>> mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle
>> mingw32-libtasn1 \
>> mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 \
>> --
>> 1.8.3.1
>>
>
> Queued, thanks. (Conflicts with Marc-Andre's "d8204b57c5 tests: make
> address@hidden run sanitizers" but easy enough to resolve.)
This is why I prefer one single package per line (like the Debian
Dockerfiles) so the diff is easier to review, and there is no merge
conflict (no performance penalty neither).
"sort dockerfiles" added to my 2.13 TODO.