Re: [Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

[Xiao Guangrong]

On 03/15/2018 07:37 PM, Dr. David Alan Gilbert wrote:
> * address@hidden (address@hidden) wrote:
> > From: Xiao Guangrong <address@hidden>
> >
> > Abstract the common function control_save_page() to cleanup the code,
> > no logic is changed
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Thank you, Dave!

> >   
> > +/*
> > + * @pages: the number of pages written by the control path,
> > + *        < 0 - error
> > + *        > 0 - number of pages written
>
> What about 0 !

The control patch does not support 0 (means duplication). :)

Based on the implementation of qemu_rdma_save_page(), if any data
is properly posted out, @bytes_sent is set to 1, otherwise a error
is detected...