[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu master build failure
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] qemu master build failure |
Date: |
Fri, 16 Mar 2018 19:12:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Does it make sense to have something like
diff --git a/configure b/configure
index 831ebf2..67d7ae3 100755
--- a/configure
+++ b/configure
@@ -552,6 +552,10 @@ else
pwd_is_source_path="n"
fi
+if test -f $source_path\/qemu-version.h -a $pwd_is_source_path = "n" ; then
+error_exit "source path contains a stale configuration, cannot build outside"
+fi
+
check_define() {
cat > $TMPC <<EOF
#if !defined($1)
On 03/16/2018 06:11 PM, Paolo Bonzini wrote:
> On 16/03/2018 18:01, Andrew Jones wrote:
>> Hi Thomas,
>>
>> QEMU master is failing to build on an AArch64 machine with GCC 4.8. I get
>>
>> ...
>> CC qemu-nbd.o
>> /home/drjones/code/qemu/qemu-nbd.c: In function ‘version’:
>> /home/drjones/code/qemu/qemu-nbd.c:133:7: error: expected ‘)’ before
>> ‘QEMU_FULL_VERSION’
>> "%s " QEMU_FULL_VERSION "\n"
>> ^
>> /home/drjones/code/qemu/qemu-nbd.c:139:5: error: format ‘%s’ expects a
>> matching ‘char *’ argument [-Werror=format=]
>> , name);
>> ^
>> cc1: all warnings being treated as errors
>> make: *** [qemu-nbd.o] Error 1
>>
>>
>> Reverting 7e563bfb8 fixes the build. I figured I'd report it now,
>> but I won't have time to look closer until Monday.
>
> You probably have a stray qemu-version.h file somewhere. No worries, I
> was puzzled by the same thing after I applied Thomas's patch. :)
>
> Paolo
>