[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 24/26] RISC-V: Clear mtval/stval on exceptions wi
From: |
Michael Clark |
Subject: |
[Qemu-devel] [PATCH v4 24/26] RISC-V: Clear mtval/stval on exceptions without info |
Date: |
Mon, 19 Mar 2018 14:18:47 -0700 |
mtval/stval must be set on all exceptions but zero is
a legal value if there is no exception specific info.
Placing the instruction bytes for illegal instruction
exceptions in mtval/stval is an optional feature and
is currently not supported by QEMU RISC-V.
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Palmer Dabbelt <address@hidden>
Signed-off-by: Michael Clark <address@hidden>
---
target/riscv/helper.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/target/riscv/helper.c b/target/riscv/helper.c
index cfbf1d1..cdce68d 100644
--- a/target/riscv/helper.c
+++ b/target/riscv/helper.c
@@ -502,6 +502,10 @@ void riscv_cpu_do_interrupt(CPUState *cs)
": badaddr 0x" TARGET_FMT_lx, env->mhartid, env->badaddr);
}
env->sbadaddr = env->badaddr;
+ } else {
+ /* otherwise we must clear sbadaddr/stval
+ * todo: support populating stval on illegal instructions */
+ env->sbadaddr = 0;
}
target_ulong s = env->mstatus;
@@ -523,6 +527,10 @@ void riscv_cpu_do_interrupt(CPUState *cs)
": badaddr 0x" TARGET_FMT_lx, env->mhartid, env->badaddr);
}
env->mbadaddr = env->badaddr;
+ } else {
+ /* otherwise we must clear mbadaddr/mtval
+ * todo: support populating mtval on illegal instructions */
+ env->mbadaddr = 0;
}
target_ulong s = env->mstatus;
--
2.7.0
- [Qemu-devel] [PATCH v4 03/26] RISC-V: Make virt board description match spike, (continued)
- [Qemu-devel] [PATCH v4 03/26] RISC-V: Make virt board description match spike, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 10/26] RISC-V: Hold rcu_read_lock when accessing memory, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 09/26] RISC-V: Include intruction hex in disassembly, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 07/26] RISC-V: Remove unused class definitions, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 12/26] RISC-V: Update E order and I extension order, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 13/26] RISC-V: Make some header guards more specific, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 16/26] RISC-V: Remove EM_RISCV ELF_MACHINE indirection, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 11/26] RISC-V: Improve page table walker spec compliance, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 17/26] RISC-V: Hardwire satp to 0 for no-mmu case, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 14/26] RISC-V: Make virt header comment title consistent, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 24/26] RISC-V: Clear mtval/stval on exceptions without info,
Michael Clark <=
- [Qemu-devel] [PATCH v4 21/26] RISC-V: No traps on writes to misa, minstret, mcycle, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 20/26] RISC-V: vectored traps are optional, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 15/26] RISC-V: Use memory_region_is_ram in pte update, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 22/26] RISC-V: Remove support for adhoc X_COP interrupt, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 23/26] RISC-V: Convert cpu definition towards future model, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 25/26] RISC-V: Remove erroneous comment from translate.c, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 19/26] RISC-V: riscv-qemu port supports sv39 and sv48, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 18/26] RISC-V: Remove braces from satp case statement, Michael Clark, 2018/03/19
- [Qemu-devel] [PATCH v4 26/26] RISC-V: Fix riscv_isa_string memory size bug, Michael Clark, 2018/03/19