[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster siz
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create |
Date: |
Tue, 20 Mar 2018 18:36:27 +0100 |
It's unclear what the real maximum cluster size is for the Parallels
format, but let's at least make sure that we don't get integer
overflows in our .bdrv_co_create implementation.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/parallels.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/parallels.c b/block/parallels.c
index 2da5e56a9d..e4ca018c2e 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -526,6 +526,11 @@ static int coroutine_fn
parallels_co_create(BlockdevCreateOptions* opts,
cl_size = DEFAULT_CLUSTER_SIZE;
}
+ /* XXX What is the real limit here? This is an insanely large maximum. */
+ if (cl_size >= UINT64_MAX / MAX_PARALLELS_IMAGE_FACTOR) {
+ error_setg(errp, "Cluster size is too large");
+ return -EINVAL;
+ }
if (total_size >= MAX_PARALLELS_IMAGE_FACTOR * cl_size) {
error_setg(errp, "Image size is too large for this cluster size");
return -E2BIG;
--
2.13.6
- Re: [Qemu-devel] [PATCH for-2.12 04/12] qemu-iotests: Enable 025 for luks, (continued)
- [Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create,
Kevin Wolf <=
- [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno, Kevin Wolf, 2018/03/20