[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make ARM space+commpage continuous |
|
Date: |
Tue, 20 Mar 2018 18:57:45 +0000 |
On 20 March 2018 at 18:49, Luke Shumaker <address@hidden> wrote:
> On Fri, 02 Mar 2018 09:13:12 -0500,
> Peter Maydell wrote:
>> On 28 December 2017 at 18:08, Luke Shumaker <address@hidden> wrote:
>> > + guest_full_size =
>> > + (0xffff0f00 & qemu_host_page_mask) + qemu_host_page_size;
> ^
>> I think this is probably more clearly written as 0x100000000ULL,
>> since rounding down to the host-page-size then adding the host-page-size
>> gets us the full 32-bit size of the guest address space.
>
> Wait, is that right? Isn't that only true if qemu_host_page_size is
> at least 8KiB (16 bits), enough to fill the zero in the middle? Won't
> a typical qemu_host_page_size be only 4KiB?
Yeah, I just got the arithmetic wrong here because I had it
stuck in my head that the commpage was the top page of the
guest address space.
-- PMM