Re: [Qemu-devel] [PATCH v3 00/49] qapi: add #if pre-processor conditions to generated code

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 00/49] qapi: add #if pre-processor conditions 
to generated code

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ca50a2d8e3 RFC: make RTC_CHANGE per-target
032f3d2f59 qapi: remove qmp_unregister_command()
7a4b17cf54 qapi: make query-cpu-definitions depend on specific targets
557f536176 qapi: make query-cpu-model-expansion depend on s390 or x86
dc1b218319 qapi: make query-gic-capabilities depend on TARGET_ARM
af9625c6c3 target.json: add a note about query-cpu* not being s390x-specific
c9801977e9 qapi: make s390 commands depend on TARGET_S390X
6a49803445 qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386
13b093aaae qapi: add a top-unit 'target' schema
8e42b4bfd8 RFC: qapi: learn to split schema by 'top-unit'
2984459cd6 qapi-commands: don't initialize command list in qmp_init_marshall()
7c39c807b5 build-sys: move qmp-introspect per target
af7d5d518d qapi: add conditions to REPLICATION type/commands on the schema
9e583d1a1d qapi: add conditions to SPICE type/commands/events on the schema
8bc16dec62 qapi: add conditions to VNC type/commands/events on the schema
72664dbe15 qapi2texi: add condition to variants
d7ff0ab4ef qapi2texi: add 'If:' condition to struct members
bde44a6b1d qapi2texi: add 'If:' condition to enum values
c87e1bc65f qapi2texi: add 'If:' section to generated documentation
3364d5099f docs: document schema configuration
77f7bafdc4 qapi: add #if conditions to generated code members
a95929de93 qapi: add 'if' to alternate members
b205d6198c qapi: add 'if' on union members
9613ba2cc2 qapi: add an error in case a discriminator is conditionnal
cd025039c0 qapi: add 'if' to implicit struct members
6799c824a8 qapi: add a dictionary form with 'type' key for members
c5b50ed9e3 qapi: rename allow_dict to allow_implicit
ba4011e602 qapi-event: add 'if' condition to implicit event enum
7d828e85b9 qapi: add 'if' to enum members
a20c2dc973 qapi: add a dictionnary form with 'name' key for enum members
061635eff1 qapi: factor out check_known_keys()
b0ad9a471a tests: modify visit_enum_type() in test-qapi to print members
86933fb39c qapi: change enum visitor to take QAPISchemaMember
cd6fb8e83f qapi: rename QAPISchemaEnumType.values to .members
31ea46dcec qapi: do not define enumeration value explicitely
55c7453f3c qapi-types: add #if conditions to types & visitors
4507e44d86 qapi-types: refactor variants handling
9c91a8fa1d qapi/events: add #if conditions to events
7ba12f474f qapi/commands: add #if conditions to commands
fcf4dfeb56 qapi-introspect: add preprocessor conditions to generated QLit
51163f6ba0 qapi-introspect: modify to_qlit() to append ', ' on level > 0
75baac460c qapi: add #if/#endif helpers
a001949a31 qapi: mcgen() shouldn't indent # lines
a2ef5afa63 qapi: add 'ifcond' to visitor methods
688755b5fd qapi: leave the ifcond attribute undefined until check()
0566f4cb49 qapi: pass 'if' condition into QAPISchemaEntity objects
7b98d1b34c qapi: add 'if' to top-level expressions
6c36d8fa28 qapi/events: generate event enum in main module
7ced623f53 qapi/visit: remove useless prefix argument

=== OUTPUT BEGIN ===
Checking PATCH 1/49: qapi/visit: remove useless prefix argument...
Checking PATCH 2/49: qapi/events: generate event enum in main module...
Checking PATCH 3/49: qapi: add 'if' to top-level expressions...
Checking PATCH 4/49: qapi: pass 'if' condition into QAPISchemaEntity objects...
Checking PATCH 5/49: qapi: leave the ifcond attribute undefined until check()...
Checking PATCH 6/49: qapi: add 'ifcond' to visitor methods...
Checking PATCH 7/49: qapi: mcgen() shouldn't indent # lines...
Checking PATCH 8/49: qapi: add #if/#endif helpers...
Checking PATCH 9/49: qapi-introspect: modify to_qlit() to append ', ' on level 
> 0...
Checking PATCH 10/49: qapi-introspect: add preprocessor conditions to generated 
QLit...
Checking PATCH 11/49: qapi/commands: add #if conditions to commands...
WARNING: line over 80 characters
#53: FILE: scripts/qapi/commands.py:289:
+            self._regy.add(gen_register_command(name, success_response, 
allow_oob))

total: 0 errors, 1 warnings, 49 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/49: qapi/events: add #if conditions to events...
WARNING: line over 80 characters
#27: FILE: scripts/qapi/events.py:190:
+            self._genc.add(gen_event_send(name, arg_type, boxed, 
self._enum_name))

total: 0 errors, 1 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/49: qapi-types: refactor variants handling...
Checking PATCH 14/49: qapi-types: add #if conditions to types & visitors...
Checking PATCH 15/49: qapi: do not define enumeration value explicitely...
Checking PATCH 16/49: qapi: rename QAPISchemaEnumType.values to .members...
Checking PATCH 17/49: qapi: change enum visitor to take QAPISchemaMember...
Checking PATCH 18/49: tests: modify visit_enum_type() in test-qapi to print 
members...
Checking PATCH 19/49: qapi: factor out check_known_keys()...
Checking PATCH 20/49: qapi: add a dictionnary form with 'name' key for enum 
members...
Checking PATCH 21/49: qapi: add 'if' to enum members...
Checking PATCH 22/49: qapi-event: add 'if' condition to implicit event enum...
Checking PATCH 23/49: qapi: rename allow_dict to allow_implicit...
Checking PATCH 24/49: qapi: add a dictionary form with 'type' key for members...
Checking PATCH 25/49: qapi: add 'if' to implicit struct members...
Checking PATCH 26/49: qapi: add an error in case a discriminator is 
conditionnal...
Checking PATCH 27/49: qapi: add 'if' on union members...
Checking PATCH 28/49: qapi: add 'if' to alternate members...
Checking PATCH 29/49: qapi: add #if conditions to generated code members...
Checking PATCH 30/49: docs: document schema configuration...
Checking PATCH 31/49: qapi2texi: add 'If:' section to generated documentation...
Checking PATCH 32/49: qapi2texi: add 'If:' condition to enum values...
Checking PATCH 33/49: qapi2texi: add 'If:' condition to struct members...
Checking PATCH 34/49: qapi2texi: add condition to variants...
Checking PATCH 35/49: qapi: add conditions to VNC type/commands/events on the 
schema...
Checking PATCH 36/49: qapi: add conditions to SPICE type/commands/events on the 
schema...
Checking PATCH 37/49: qapi: add conditions to REPLICATION type/commands on the 
schema...
Checking PATCH 38/49: build-sys: move qmp-introspect per target...
Checking PATCH 39/49: qapi-commands: don't initialize command list in 
qmp_init_marshall()...
Checking PATCH 40/49: RFC: qapi: learn to split schema by 'top-unit'...
WARNING: line over 80 characters
#102: FILE: scripts/qapi/common.py:304:
+                        incl_info['has-pragma-top-unit'] = 
exprs_include._top_unit

WARNING: line over 80 characters
#340: FILE: scripts/qapi/events.py:165:
+        self._enum_name = c_name(self._prefix_unit() + 'QAPIEvent', 
protect=False)

total: 0 errors, 2 warnings, 350 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 41/49: qapi: add a top-unit 'target' schema...
Checking PATCH 42/49: qapi: make rtc-reset-reinjection and SEV depend on 
TARGET_I386...
Checking PATCH 43/49: qapi: make s390 commands depend on TARGET_S390X...
Checking PATCH 44/49: target.json: add a note about query-cpu* not being 
s390x-specific...
Checking PATCH 45/49: qapi: make query-gic-capabilities depend on TARGET_ARM...
Checking PATCH 46/49: qapi: make query-cpu-model-expansion depend on s390 or 
x86...
Checking PATCH 47/49: qapi: make query-cpu-definitions depend on specific 
targets...
Checking PATCH 48/49: qapi: remove qmp_unregister_command()...
Checking PATCH 49/49: RFC: make RTC_CHANGE per-target...
ERROR: line over 90 characters
#65: FILE: monitor.c:682:
+#if defined(TARGET_ALPHA) || defined(TARGET_ARM) || defined(TARGET_HPPA) || 
defined(TARGET_I386) || defined(TARGET_MIPS) | defined(TARGET_MIPS64) || 
defined(TARGET_MOXIE) || defined(TARGET_PPC) || defined(TARGET_PPC64) || 
defined(TARGET_S390X) || defined(TARGET_SH4) || defined(TARGET_SPARC)

total: 1 errors, 0 warnings, 89 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden