qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tests: Fix ubuntu.i386 image initialization


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] tests: Fix ubuntu.i386 image initialization
Date: Thu, 22 Mar 2018 05:33:22 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/22/2018 12:47 AM, Fam Zheng wrote:
> The apt-get commands we run through ssh expect certain features of the
> tty, and refuses to work if /dev/null is used. It is ugly, but easy to
> satisfy.
> 
> Actually, there is no reason to hide the output. It just makes things
> harder to diagnose. We can always redirect in the Makefile, so don't do
> it conditionally here.
> 
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  tests/vm/basevm.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> index 686d88decf..3a2d508c35 100755
> --- a/tests/vm/basevm.py
> +++ b/tests/vm/basevm.py
> @@ -107,10 +107,7 @@ class BaseVM(object):
>          assert not isinstance(cmd, str)
>          ssh_cmd += ["address@hidden" % user] + list(cmd)
>          logging.debug("ssh_cmd: %s", " ".join(ssh_cmd))
> -        r = subprocess.call(ssh_cmd,
> -                            stdin=sys.stdin if interactive else 
> self._devnull,
> -                            stdout=sys.stdout if interactive else 
> self._stdout,
> -                            stderr=sys.stderr if interactive else 
> self._stderr)
> +        r = subprocess.call(ssh_cmd)
>          if check and r != 0:
>              raise Exception("SSH command failed: %s" % cmd)
>          return r
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]