Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162

[Eric Blake]

On 03/22/2018 06:14 AM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>
> ---
>   tests/qemu-iotests/186.out | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/186.out b/tests/qemu-iotests/186.out
> index ec75c0fc60..5020162826 100644
> --- a/tests/qemu-iotests/186.out
> +++ b/tests/qemu-iotests/186.out
> @@ -404,7 +404,7 @@ Testing: -drive if=floppy
>   QEMU X.Y.Z monitor - type 'help' for more information
>   (qemu) info block
>   floppy0: [not inserted]
> -    Attached to:      /machine/unattached/device[17]
> +    Attached to:      /machine/unattached/device[13]

It looks like this name is quite flexible; would it not be better to 
enhance 186 to sed out the name (s/Attached to:.*/Attached to: PATH/) 
and then adjust the .out so that it is no longer sensitive to these 
types of internal renames?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org