[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from v
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h |
Date: |
Thu, 22 Mar 2018 17:15:30 +0200 |
On Mon, Mar 19, 2018 at 03:15:36PM +0800, Tiwei Bie wrote:
> This macro isn't used by any VFIO code. And its name is
> too generic. The vfio-common.h (in include/hw/vfio) can
> be included by other modules in QEMU. It can introduce
> conflicts.
>
> Signed-off-by: Tiwei Bie <address@hidden>
This one can go ahead immediately.
Try posting as a separate patch.
> ---
> include/hw/vfio/vfio-common.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index b820f7984c..f6aa4ae959 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -34,15 +34,6 @@
> #define ERR_PREFIX "vfio error: %s: "
> #define WARN_PREFIX "vfio warning: %s: "
>
> -/*#define DEBUG_VFIO*/
> -#ifdef DEBUG_VFIO
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> enum {
> VFIO_DEVICE_TYPE_PCI = 0,
> VFIO_DEVICE_TYPE_PLATFORM = 1,
> --
> 2.11.0
- [Qemu-devel] [PATCH v2 0/6] Extend vhost-user to support VFIO based accelerators, Tiwei Bie, 2018/03/19
- [Qemu-devel] [PATCH v2 2/6] vhost-user: introduce shared vhost-user state, Tiwei Bie, 2018/03/19
- [Qemu-devel] [PATCH v2 1/6] vhost-user: support receiving file descriptors in slave_read, Tiwei Bie, 2018/03/19
- [Qemu-devel] [PATCH v2 3/6] virtio: support adding sub-regions for notify region, Tiwei Bie, 2018/03/19
- [Qemu-devel] [PATCH v2 4/6] vfio: support getting VFIOGroup from groupfd, Tiwei Bie, 2018/03/19
- [Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h, Tiwei Bie, 2018/03/19
- Re: [Qemu-devel] [PATCH v2 5/6] vfio: remove DPRINTF() definition from vfio-common.h,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v2 6/6] vhost-user: add VFIO based accelerators support, Tiwei Bie, 2018/03/19
- Re: [Qemu-devel] [PATCH v2 0/6] Extend vhost-user to support VFIO based accelerators, Michael S. Tsirkin, 2018/03/22
- Re: [Qemu-devel] [PATCH v2 0/6] Extend vhost-user to support VFIO based accelerators, Michael S. Tsirkin, 2018/03/22