[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ccid-card: include libcacard.h only
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH] ccid-card: include libcacard.h only |
|
Date: |
Sat, 24 Mar 2018 14:38:55 +0100 |
Hi
On Sat, Mar 24, 2018 at 1:40 PM, Michal Privoznik <address@hidden> wrote:
> On 03/24/2018 12:01 PM, Marc-André Lureau wrote:
>> Hi
>>
>> On Sat, Mar 24, 2018 at 6:13 AM, Michal Privoznik <address@hidden> wrote:
>>> When trying to build with latest libcacard-2.5.1, I hit the
>>> following error:
>>>
>>> In file included from hw/usb/ccid-card-passthru.c:12:0:
>>> /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only
>>> <libcacard.h> can be included directly" [-Werror=cpp]
>>> #warning "Only <libcacard.h> can be included directly"
>>>
>>
>> The warning was promptly removed in 2.5.2:
>> https://cgit.freedesktop.org/spice/libcacard/commit/?id=998db1e88eb8219264476c022d1446f3cb4330e8
>
> Cool. But We can still include just top level header file instead of
> individual files, can't we?
Yes, if we bump libcacard version dependency. 2.5.1 (that added
top-level libcacard.h) is from 2015-11-24.
--
Marc-André Lureau