[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 dev
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device |
|
Date: |
Mon, 26 Mar 2018 14:16:54 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 26/03/2018 14:14, Thomas Huth wrote:
>> + object_ref(OBJECT(dev));
>> + object_property_set_bool(OBJECT(dev), false, "realized", &err);
>> + if (err) {
>> + error_reportf_err(err, "Clean up of device %s failed: ",
>> + object_get_typename(OBJECT(dev)));
>> + exit(1);
>> + }
>> + object_unref(OBJECT(dev));
>> +}
>
> I'm not a qdev expert, but I wonder whether we need the full object_ref
> + unref dance here? If not, you could get rid of this function and
> simply do the object_property_set_bool(OBJECT(dev), false, "realized",
> &error_fatal) twice in i8257_dma_init() instead.
No, however we do need an object_unparent call.
Paolo