qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qmp-test: fix response leak


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qmp-test: fix response leak
Date: Mon, 26 Mar 2018 13:33:52 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/26/2018 12:20 PM, Marc-André Lureau wrote:
Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26.

Signed-off-by: Marc-André Lureau <address@hidden>
---
  tests/qmp-test.c | 1 +
  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

I'll queue this through my qapi tree, unless applying Peter's for-2.12 patches fixes it differently.


diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 558e83540c..8de99a4727 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -90,6 +90,7 @@ static void test_qmp_protocol(void)
      test_version(qdict_get(q, "version"));
      capabilities = qdict_get_qlist(q, "capabilities");
      g_assert(capabilities && qlist_empty(capabilities));
+    QDECREF(resp);
/* Test valid command before handshake */
      resp = qtest_qmp(qts, "{ 'execute': 'query-version' }");


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]