qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format


From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format
Date: Tue, 27 Mar 2018 14:20:11 +0100
User-agent: Mutt/1.9.2 (2017-12-15)

Re-adding qemu-devel address - please don't drop the mailing list from
CC's when replying to messages on the list.

On Tue, Mar 27, 2018 at 06:46:19PM +0530, satheesh rajendran wrote:
> On Tue, Mar 27, 2018 at 01:40:00PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Mar 27, 2018 at 06:08:00PM +0530, address@hidden wrote:
> > > From: Satheesh Rajendran <address@hidden>
> > > 
> > > This commit 137b5cb6ab565cb3781d5337591e155932b4230e
> > > refactors info cpus output and changes output format from
> > > 'thread_id' to 'thread-id', this would break parsing
> > > of output in above layers like libvirt, test framework etc.
> > 
> > Libvirt doesn't use HMP, only QMP, so this shouldn't have broken libvirt
> > afaik.  HMP is not intended to be a stable API so these kind of changes
> > should be expected.
> 
> Am sure avocado test framework uses this output for parsing to extract 
> threadid

If avocado is relying on the HMP then it should be updated to use QMP,
as HMP is not a stable API for automation.

> and in libvirt atleast I checked below code uses it, I hope keeping the
> format same as previous won't affect anything?
> 
> in src/qemu/qemu_monitor_text.c
> int
> qemuMonitorTextQueryCPUs(qemuMonitorPtr mon,
>                          struct qemuMonitorQueryCpusEntry **entries,
>                          size_t *nentries)
> ...

This libvirt code is only executed when managing QEMU versions < 0.15,
so not affected.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]