qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 06/14] qmp: fix qmp_capabilities error regression


From: Eric Blake
Subject: Re: [Qemu-devel] [PULL 06/14] qmp: fix qmp_capabilities error regression
Date: Tue, 27 Mar 2018 10:16:48 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/27/2018 10:01 AM, Marc-André Lureau wrote:
On Tue, Mar 27, 2018 at 4:30 PM, Eric Blake <address@hidden> wrote:
From: Peter Xu <address@hidden>

When someone sends a command before QMP handshake, the error used to be
like this:

  {"execute": "query-cpus"}
  {"error": {"class": "CommandNotFound", "desc":
             "Expecting capabilities negotiation with 'qmp_capabilities'"}}

While after cf869d5317 it becomes:

  {"execute": "query-cpus"}
  {"error": {"class": "CommandNotFound", "desc":
             "The command query-cpus has not been found"}}

Fix it back to the nicer one.

Fixes: cf869d5317 ("qmp: support out-of-band (oob) execution", 2018-03-19)
Reported-by: Marc-André Lureau <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reported-by: Marc-André Lureau <address@hidden>

Reviewed-by (not x2 Reported-by ;)


Shoot.  Want me to send a v2 pull request?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]