[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 07/10] migration: move calling control_save_page
From: |
guangrong . xiao |
Subject: |
[Qemu-devel] [PATCH v3 07/10] migration: move calling control_save_page to the common place |
Date: |
Fri, 30 Mar 2018 15:51:25 +0800 |
From: Xiao Guangrong <address@hidden>
The function is called by both ram_save_page and ram_save_target_page,
so move it to the common caller to cleanup the code
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Xiao Guangrong <address@hidden>
---
migration/ram.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index c3628b020e..e0caf7182b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1037,10 +1037,6 @@ static int ram_save_page(RAMState *rs, PageSearchStatus
*pss, bool last_stage)
p = block->host + offset;
trace_ram_save_page(block->idstr, (uint64_t)offset, p);
- if (control_save_page(rs, block, offset, &pages)) {
- return pages;
- }
-
XBZRLE_cache_lock();
pages = save_zero_page(rs, block, offset);
if (pages > 0) {
@@ -1198,10 +1194,6 @@ static int ram_save_compressed_page(RAMState *rs,
PageSearchStatus *pss,
p = block->host + offset;
- if (control_save_page(rs, block, offset, &pages)) {
- return pages;
- }
-
/* When starting the process of a new block, the first page of
* the block should be sent out before other pages in the same
* block, and all the pages in last block should have been sent
@@ -1489,6 +1481,14 @@ err:
static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
bool last_stage)
{
+ RAMBlock *block = pss->block;
+ ram_addr_t offset = pss->page << TARGET_PAGE_BITS;
+ int res;
+
+ if (control_save_page(rs, block, offset, &res)) {
+ return res;
+ }
+
/*
* If xbzrle is on, stop using the data compression after first
* round of migration even if compression is enabled. In theory,
--
2.14.3
- [Qemu-devel] [PATCH v3 00/10] migration: improve and cleanup compression, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 01/10] migration: stop compressing page in migration thread, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 02/10] migration: stop compression to allocate and free memory frequently, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 03/10] migration: stop decompression to allocate and free memory frequently, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 04/10] migration: detect compression and decompression errors, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 05/10] migration: introduce control_save_page(), guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 06/10] migration: move some code to ram_save_host_page, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 07/10] migration: move calling control_save_page to the common place,
guangrong . xiao <=
- [Qemu-devel] [PATCH v3 08/10] migration: move calling save_zero_page to the common place, guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 09/10] migration: introduce save_normal_page(), guangrong . xiao, 2018/03/30
- [Qemu-devel] [PATCH v3 10/10] migration: remove ram_save_compressed_page(), guangrong . xiao, 2018/03/30
- Re: [Qemu-devel] [PATCH v3 00/10] migration: improve and cleanup compression, no-reply, 2018/03/31