[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gr
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12] block: handle invalid lseek returns gracefully |
Date: |
Tue, 3 Apr 2018 15:27:10 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 03.04.2018 um 06:37 hat Jeff Cody geschrieben:
> In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a
> workaround in the gluster driver to handle invalid values returned for
> SEEK_DATA or SEEK_HOLE.
>
> In some instances, these same invalid values can be seen in the posix
> file handler as well - for example, it has been reported on FUSE gluster
> mounts.
>
> Calling assert() for these invalid values is overly harsh; we can safely
> return -EIO and allow this case to be treated as a "learned nothing"
> case (e.g., D4 / H4, as commented in the code).
>
> This patch does the same thing that 223a23c198787 did for gluster.c,
> except in file-posix.c
>
> Signed-off-by: Jeff Cody <address@hidden>
Thanks, applied to the block branch.
Kevin