[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests |
|
Date: |
Wed, 4 Apr 2018 16:42:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 04/04/2018 15:44, Alex Bennée wrote:
>>>> Signed-off-by: Miodrag Dinic <address@hidden>
>>>> Signed-off-by: Aleksandar Markovic <address@hidden>
>> Is this actually necessary? What paths are not taking the lock?
> Helpers functions have to manually take the lock. AIUI from this patch
> the if (locked) dance allows a single function to be used which may
> trigger an IRQ from both helpers (no automatic locking) and hw emulation
> (locked by default).
This makes it harder to understand which paths actually need to take the
lock, and to split the lock in the future. We do it in some cases, but
in general defining "*_locked" or "*_unlocked" functions is easier on
the brain.
Thanks,
Paolo