[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/16] translate-all: remove tb_lock mention fro
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 15/16] translate-all: remove tb_lock mention from cpu_restore_state_from_tb |
|
Date: |
Thu, 5 Apr 2018 21:40:44 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Mar 29, 2018 at 17:06:56 +0100, Alex Bennée wrote:
>
> Emilio G. Cota <address@hidden> writes:
>
> > tb_lock was needed when the function did retranslation. However,
> > since fca8a500d519 ("tcg: Save insn data and use it in
> > cpu_restore_state_from_tb") we don't do retranslation.
> >
> > Get rid of the comment.
>
> I think we need to modify the comment in cpu_restore_state as well:
>
> Either way we need return early as we can't resolve it here.
Thanks, I've added this suggestion to patch 16/16.
E.
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 15/16] translate-all: remove tb_lock mention from cpu_restore_state_from_tb,
Emilio G. Cota <=