Re: [Qemu-devel] [PATCH 02/19] target/hppa: Begin using scripts/decodetree.py

[Bastian Koppelmann]

On 02/17/2018 09:31 PM, Richard Henderson wrote:
> Convert the BREAK instruction to start.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/hppa/translate.c   | 14 +++++++++++---
>  target/hppa/Makefile.objs |  8 ++++++++
>  target/hppa/insns.decode  | 24 ++++++++++++++++++++++++
>  3 files changed, 43 insertions(+), 3 deletions(-)
>  create mode 100644 target/hppa/insns.decode
> 
[...]
> +#
> +
> +####
> +# System
> +####
> +
> +break                000000 ----- ----- --- 00000000 -----
> 

Why are the im13 and im5 fields don't care? Is nobody using them?

Other than that,
Reviewed-by: Bastian Koppelmann <address@hidden>

Cheers,
Bastian