qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device


From: Christian König
Subject: Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device
Date: Fri, 6 Apr 2018 14:24:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

Am 06.04.2018 um 11:33 schrieb Gerd Hoffmann:
   Hi,

The pages backing a DMA-buf are not allowed to move (at least not without a
patch set I'm currently working on), but for certain MM operations to work
correctly you must be able to modify the page tables entries and move the
pages backing them around.

For example try to use fork() with some copy on write pages with this
approach. You will find that you have only two options to correctly handle
this.
The fork() issue should go away with shared memory pages (no cow).
I guess this is the reason why vgem is internally backed by shmem.

Yes, exactly that is also an approach which should work fine. Just don't try to get this working with get_user_pages().


Hmm.  So I could try to limit the udmabuf driver to shmem too (i.e.
have the ioctl take a shmem filehandle and offset instead of a virtual
address).

But maybe it is better then to just extend vgem, i.e. add support to
create gem objects from existing shmem.

Comments?

Yes, extending vgem instead of creating something new sounds like a good idea to me as well.

Regards,
Christian.


cheers,
   Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]