[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.12] gdbstub: fix off-by-one in gdb_handle_packet() |
|
Date: |
Mon, 9 Apr 2018 11:39:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 09/04/2018 07:58, Stefan Hajnoczi wrote:
> On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote:
>> memtohex() adds an extra trailing NUL character.
>>
>> Reported-by: AddressSanitizer
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> (gdb) dump binary memory /tmp/dram.bin 0x94000000 0x94100000
>> Remote connection closed
>>
>> =================================================================
>> ==22732==ERROR: AddressSanitizer: stack-buffer-overflow on address
>> 0x7ffe43018340 at pc 0x55f2655fde81 bp 0x7ffe43017210 sp 0x7ffe43017208
>> WRITE of size 1 at 0x7ffe43018340 thread T0
>>
>> ---
>> gdbstub.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Peter, can you apply this directly to master?
Thanks,
Paolo
signature.asc
Description: OpenPGP digital signature