[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextB
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase |
Date: |
Tue, 10 Apr 2018 13:22:30 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
>
> - pc and npc are left unmodified, since they can point to out-of-TB
> jump targets.
>
> - Got rid of last_pc in gen_intermediate_code(), using base.pc_next
> instead. Only update pc_next (1) on a breakpoint (so that tb->size
> includes the insn), and (2) after reading the current instruction
> from memory. This allows us to use base.pc_next in the BP check,
> which is what the translator loop does.
>
> Cc: Mark Cave-Ayland <address@hidden>
> Cc: Artyom Tarasenko <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/sparc/translate.c | 92
> +++++++++++++++++++++++-------------------------
> 1 file changed, 45 insertions(+), 47 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 05/17] target/sparc: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 03/17] target/sparc: convert to DisasJumpType, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 02/17] target/sh4: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 13/17] target/openrisc: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
- Re: [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 01/17] translator: merge max_insns into DisasContextBase, Emilio G. Cota, 2018/04/06