[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets |
|
Date: |
Tue, 10 Apr 2018 14:05:10 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/10/2018 01:29 PM, Max Filippov wrote:
> On Mon, Apr 9, 2018 at 8:20 PM, Richard Henderson
> <address@hidden> wrote:
>> On 04/10/2018 12:17 PM, Max Filippov wrote:
>>> + uint64_t off = tlow |
>>> + ((unsigned long long)thigh << TARGET_LONG_BITS / 2) <<
>>
>> There's a second instance of long long here; needs uint64_t.
>
> Ehh, will fix.
> BTW, why is uint64_t here better than unsigned long long? Just
> shorter?
Because it's more explicit about the number of bits we're talking about.
r~