Re: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to a

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to a

From:	no-reply
Subject:	Re: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to arch directories
Date:	Wed, 11 Apr 2018 12:22:44 -0700 (PDT)
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to 
arch directories

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b8200121c0 linux-user: define TARGET_ARCH_HAS_SETUP_FRAME
1c33964700 linux-user: move ppc/ppc64 signal.c parts to ppc directory
f8baf51675 linux-user: move mips/mips64 signal.c parts to mips directory
da511d0ec7 linux-user: move sparc/sparc64 signal.c parts to sparc directory
e1ad8f443e linux-user: move i386/x86_64 signal.c parts to i386 directory
b2dba996c9 linux-user: move xtensa signal.c parts to xtensa directory
33a303fd45 linux-user: move hppa signal.c parts to hppa directory
9e8ca47db2 linux-user: move riscv signal.c parts to riscv directory
9e4c7dd51c linux-user: move tilegx signal.c parts to tilegx directory
7cf07bd709 linux-user: move alpha signal.c parts to alpha directory
15c702a466 linux-user: move m68k signal.c parts to m68k directory
e36b1c7fa1 linux-user: move s390x signal.c parts to s390x directory
dfde7dcf26 linux-user: move openrisc signal.c parts to openrisc directory
77679be421 linux-user: move nios2 signal.c parts to nios2 directory
0bc1083544 linux-user: move cris signal.c parts to cris directory
69b1454cda linux-user: move microblaze signal.c parts to microblaze directory
5442673d4d linux-user: move sh4 signal.c parts to sh4 directory
499bcd5f1c linux-user: move arm signal.c parts to arm directory
7328bbf943 linux-user: move aarch64 signal.c parts to aarch64 directory
603a10d154 linux-user: create a dummy per arch signal.c

=== OUTPUT BEGIN ===
Checking PATCH 1/20: linux-user: create a dummy per arch signal.c...
Checking PATCH 2/20: linux-user: move aarch64 signal.c parts to aarch64 
directory...
Checking PATCH 3/20: linux-user: move arm signal.c parts to arm directory...
ERROR: open brace '{' following struct go on the same line
#109: FILE: linux-user/arm/signal.c:102:
+struct sigframe_v1
+{

ERROR: spaces required around that '-' (ctx:VxV)
#111: FILE: linux-user/arm/signal.c:104:
+    abi_ulong extramask[TARGET_NSIG_WORDS-1];
                                          ^

ERROR: open brace '{' following struct go on the same line
#116: FILE: linux-user/arm/signal.c:109:
+struct sigframe_v2
+{

ERROR: open brace '{' following struct go on the same line
#122: FILE: linux-user/arm/signal.c:115:
+struct rt_sigframe_v1
+{

ERROR: open brace '{' following struct go on the same line
#131: FILE: linux-user/arm/signal.c:124:
+struct rt_sigframe_v2
+{

WARNING: line over 80 characters
#142: FILE: linux-user/arm/signal.c:135:
+#define SWI_SYS_SIGRETURN       (0xef000000|(TARGET_NR_sigreturn + 
ARM_SYSCALL_BASE))

ERROR: spaces required around that '|' (ctx:VxV)
#142: FILE: linux-user/arm/signal.c:135:
+#define SWI_SYS_SIGRETURN       (0xef000000|(TARGET_NR_sigreturn + 
ARM_SYSCALL_BASE))
                                            ^

WARNING: line over 80 characters
#143: FILE: linux-user/arm/signal.c:136:
+#define SWI_SYS_RT_SIGRETURN    (0xef000000|(TARGET_NR_rt_sigreturn + 
ARM_SYSCALL_BASE))

ERROR: spaces required around that '|' (ctx:VxV)
#143: FILE: linux-user/arm/signal.c:136:
+#define SWI_SYS_RT_SIGRETURN    (0xef000000|(TARGET_NR_rt_sigreturn + 
ARM_SYSCALL_BASE))
                                            ^

WARNING: line over 80 characters
#150: FILE: linux-user/arm/signal.c:143:
+#define SWI_THUMB_RT_SIGRETURN  (0xdf00 << 16 | 0x2700 | 
(TARGET_NR_rt_sigreturn))

ERROR: "(foo*)" should be "(foo *)"
#261: FILE: linux-user/arm/signal.c:254:
+    return (abi_ulong*)(vfpframe+1);

ERROR: spaces required around that '+' (ctx:VxV)
#261: FILE: linux-user/arm/signal.c:254:
+    return (abi_ulong*)(vfpframe+1);
                                 ^

ERROR: "(foo*)" should be "(foo *)"
#281: FILE: linux-user/arm/signal.c:274:
+    return (abi_ulong*)(iwmmxtframe+1);

ERROR: spaces required around that '+' (ctx:VxV)
#281: FILE: linux-user/arm/signal.c:274:
+    return (abi_ulong*)(iwmmxtframe+1);
                                    ^

ERROR: space required before the open parenthesis '('
#313: FILE: linux-user/arm/signal.c:306:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: space required before the open parenthesis '('
#333: FILE: linux-user/arm/signal.c:326:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: space required before the open parenthesis '('
#410: FILE: linux-user/arm/signal.c:403:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: space required before the open parenthesis '('
#524: FILE: linux-user/arm/signal.c:517:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: if this code is redundant consider removing it
#535: FILE: linux-user/arm/signal.c:528:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#537: FILE: linux-user/arm/signal.c:530:
+    if (ptrace_cancel_bpt(current))
[...]

ERROR: "(foo*)" should be "(foo *)"
#575: FILE: linux-user/arm/signal.c:568:
+    return (abi_ulong*)(vfpframe + 1);

ERROR: "(foo*)" should be "(foo *)"
#600: FILE: linux-user/arm/signal.c:593:
+    return (abi_ulong*)(iwmmxtframe + 1);

ERROR: braces {} are necessary for all arms of this statement
#613: FILE: linux-user/arm/signal.c:606:
+    if (restore_sigcontext(env, &uc->tuc_mcontext))
[...]

ERROR: if this code is redundant consider removing it
#637: FILE: linux-user/arm/signal.c:630:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#639: FILE: linux-user/arm/signal.c:632:
+    if (ptrace_cancel_bpt(current))
[...]

ERROR: line over 90 characters
#719: FILE: linux-user/arm/signal.c:712:
+    if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1, 
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)

ERROR: braces {} are necessary for all arms of this statement
#719: FILE: linux-user/arm/signal.c:712:
+    if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v1, 
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
[...]

ERROR: if this code is redundant consider removing it
#722: FILE: linux-user/arm/signal.c:715:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#724: FILE: linux-user/arm/signal.c:717:
+    if (ptrace_cancel_bpt(current))
[...]

total: 26 errors, 3 warnings, 1524 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/20: linux-user: move sh4 signal.c parts to sh4 directory...
ERROR: open brace '{' following struct go on the same line
#59: FILE: linux-user/sh4/signal.c:52:
+struct target_sigframe
+{

ERROR: spaces required around that '-' (ctx:VxV)
#61: FILE: linux-user/sh4/signal.c:54:
+    target_ulong extramask[TARGET_NSIG_WORDS-1];
                                             ^

ERROR: open brace '{' following struct go on the same line
#75: FILE: linux-user/sh4/signal.c:68:
+struct target_rt_sigframe
+{

ERROR: spaces required around that '|' (ctx:VxV)
#82: FILE: linux-user/sh4/signal.c:75:
+#define MOVW(n)  (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
                         ^

ERROR: spaces required around that '-' (ctx:VxV)
#82: FILE: linux-user/sh4/signal.c:75:
+#define MOVW(n)  (0x9300|((n)-2)) /* Move mem word at PC+n to R3 */
                              ^

ERROR: spaces required around that '=' (ctx:VxV)
#138: FILE: linux-user/sh4/signal.c:131:
+    for (i=0; i<16; i++) {
           ^

ERROR: spaces required around that '<' (ctx:VxV)
#138: FILE: linux-user/sh4/signal.c:131:
+    for (i=0; i<16; i++) {
                ^

ERROR: spaces required around that '=' (ctx:VxV)
#166: FILE: linux-user/sh4/signal.c:159:
+    for (i=0; i<16; i++) {
           ^

ERROR: spaces required around that '<' (ctx:VxV)
#166: FILE: linux-user/sh4/signal.c:159:
+    for (i=0; i<16; i++) {
                ^

ERROR: space required before the open parenthesis '('
#256: FILE: linux-user/sh4/signal.c:249:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: space required before the open parenthesis '('
#306: FILE: linux-user/sh4/signal.c:299:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#310: FILE: linux-user/sh4/signal.c:303:
+    if (err)
[...]

total: 12 errors, 0 warnings, 679 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/20: linux-user: move microblaze signal.c parts to microblaze 
directory...
ERROR: return is not a function, parentheses are not required
#148: FILE: linux-user/microblaze/signal.c:140:
+    return ((sp - frame_size) & -8UL);

ERROR: braces {} are necessary for all arms of this statement
#160: FILE: linux-user/microblaze/signal.c:152:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]

ERROR: space required before the open parenthesis '('
#166: FILE: linux-user/microblaze/signal.c:158:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: spaces required around that '-' (ctx:VxV)
#176: FILE: linux-user/microblaze/signal.c:168:
+        env->regs[15] = ((unsigned long)ka->sa_restorer)-8;
                                                         ^

ERROR: braces {} are necessary for all arms of this statement
#228: FILE: linux-user/microblaze/signal.c:220:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]

ERROR: space required before the open parenthesis '('
#233: FILE: linux-user/microblaze/signal.c:225:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

total: 6 errors, 0 warnings, 476 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/20: linux-user: move cris signal.c parts to cris directory...
ERROR: braces {} are necessary for all arms of this statement
#116: FILE: linux-user/cris/signal.c:109:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]

ERROR: spaces required around that '+' (ctx:VxV)
#126: FILE: linux-user/cris/signal.c:119:
+    __put_user(0x9c5f, frame->retcode+0);
                                      ^

ERROR: space required before the open parenthesis '('
#134: FILE: linux-user/cris/signal.c:127:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: space required before the open parenthesis '('
#177: FILE: linux-user/cris/signal.c:170:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

total: 4 errors, 0 warnings, 358 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/20: linux-user: move nios2 signal.c parts to nios2 directory...
Checking PATCH 8/20: linux-user: move openrisc signal.c parts to openrisc 
directory...
ERROR: if this code is redundant consider removing it
#57: FILE: linux-user/openrisc/signal.c:49:
+#if 0

total: 1 errors, 0 warnings, 441 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/20: linux-user: move s390x signal.c parts to s390x directory...
ERROR: spaces required around that '*' (ctx:VxV)
#43: FILE: linux-user/s390x/signal.c:35:
+#define _SIGMASK_COPY_SIZE    (sizeof(unsigned long)*_SIGCONTEXT_NSIG_WORDS)
                                                     ^

WARNING: line over 80 characters
#44: FILE: linux-user/s390x/signal.c:36:
+#define PSW_ADDR_AMODE            0x0000000000000000UL /* 0x80000000UL for 
31-bit */

ERROR: do not use C99 // comments
#120: FILE: linux-user/s390x/signal.c:112:
+    //save_access_regs(current->thread.acrs); FIXME

ERROR: do not use C99 // comments
#136: FILE: linux-user/s390x/signal.c:128:
+    //save_fp_regs(&current->thread.fp_regs); FIXME

ERROR: do not use C99 // comments
#180: FILE: linux-user/s390x/signal.c:172:
+    env->regs[2] = sig; //map_signal(sig);

ERROR: do not use C99 // comments
#185: FILE: linux-user/s390x/signal.c:177:
+    env->regs[4] = 0; // FIXME: no clue... current->thread.trap_no;

ERROR: do not use C99 // comments
#186: FILE: linux-user/s390x/signal.c:178:
+    env->regs[5] = 0; // FIXME: no clue... current->thread.prot_addr;

ERROR: do not use C99 // comments
#243: FILE: linux-user/s390x/signal.c:235:
+    env->regs[2] = sig; //map_signal(sig);

total: 7 errors, 1 warnings, 634 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/20: linux-user: move m68k signal.c parts to m68k directory...
ERROR: open brace '{' following struct go on the same line
#44: FILE: linux-user/m68k/signal.c:37:
+struct target_sigframe
+{

ERROR: spaces required around that '-' (ctx:VxV)
#50: FILE: linux-user/m68k/signal.c:43:
+    abi_ulong extramask[TARGET_NSIG_WORDS-1];
                                          ^

ERROR: spaces required around that '*' (ctx:VxV)
#60: FILE: linux-user/m68k/signal.c:53:
+    int f_fpregs[8*3];
                   ^

ERROR: open brace '{' following struct go on the same line
#81: FILE: linux-user/m68k/signal.c:74:
+struct target_rt_sigframe
+{

ERROR: space prohibited between function name and open parenthesis '('
#132: FILE: linux-user/m68k/signal.c:125:
+    if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {

ERROR: return is not a function, parentheses are not required
#136: FILE: linux-user/m68k/signal.c:129:
+    return ((sp - frame_size) & -8UL);

ERROR: space required before the open parenthesis '('
#161: FILE: linux-user/m68k/signal.c:154:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#264: FILE: linux-user/m68k/signal.c:257:
+    if (temp != TARGET_MCONTEXT_VERSION)
[...]

ERROR: braces {} are necessary for all arms of this statement
#336: FILE: linux-user/m68k/signal.c:329:
+    if (err)
[...]

ERROR: space required before the open parenthesis '('
#339: FILE: linux-user/m68k/signal.c:332:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#354: FILE: linux-user/m68k/signal.c:347:
+    if (err)
[...]

ERROR: braces {} are necessary for all arms of this statement
#379: FILE: linux-user/m68k/signal.c:372:
+    if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]

ERROR: space required before the open parenthesis '('
#386: FILE: linux-user/m68k/signal.c:379:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#412: FILE: linux-user/m68k/signal.c:405:
+    if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]

ERROR: braces {} are necessary for all arms of this statement
#420: FILE: linux-user/m68k/signal.c:413:
+    if (target_rt_restore_ucontext(env, &frame->uc))
[...]

total: 15 errors, 0 warnings, 836 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/20: linux-user: move alpha signal.c parts to alpha 
directory...
Checking PATCH 12/20: linux-user: move tilegx signal.c parts to tilegx 
directory...
Checking PATCH 13/20: linux-user: move riscv signal.c parts to riscv 
directory...
Checking PATCH 14/20: linux-user: move hppa signal.c parts to hppa directory...
Checking PATCH 15/20: linux-user: move xtensa signal.c parts to xtensa 
directory...
Checking PATCH 16/20: linux-user: move i386/x86_64 signal.c parts to i386 
directory...
ERROR: spaces required around that '-' (ctx:VxV)
#176: FILE: linux-user/i386/signal.c:167:
+    abi_ulong extramask[TARGET_NSIG_WORDS-1];
                                          ^

WARNING: line over 80 characters
#303: FILE: linux-user/i386/signal.c:294:
+            esp = target_sigaltstack_used.ss_sp + 
target_sigaltstack_used.ss_size;

ERROR: braces {} are necessary for all arms of this statement
#335: FILE: linux-user/i386/signal.c:326:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]

ERROR: space required before the open parenthesis '('
#343: FILE: linux-user/i386/signal.c:334:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: spaces required around that '+' (ctx:VxV)
#358: FILE: linux-user/i386/signal.c:349:
+        __put_user(val16, (uint16_t *)(frame->retcode+0));
                                                      ^

ERROR: spaces required around that '+' (ctx:VxV)
#359: FILE: linux-user/i386/signal.c:350:
+        __put_user(TARGET_NR_sigreturn, (int *)(frame->retcode+2));
                                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#361: FILE: linux-user/i386/signal.c:352:
+        __put_user(val16, (uint16_t *)(frame->retcode+6));
                                                      ^

ERROR: braces {} are necessary for all arms of this statement
#398: FILE: linux-user/i386/signal.c:389:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0))
[...]

ERROR: space required before the open parenthesis '('
#424: FILE: linux-user/i386/signal.c:415:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: spaces required around that '+' (ctx:VxV)
#438: FILE: linux-user/i386/signal.c:429:
+        __put_user(0xb8, (char *)(frame->retcode+0));
                                                 ^

ERROR: spaces required around that '+' (ctx:VxV)
#439: FILE: linux-user/i386/signal.c:430:
+        __put_user(TARGET_NR_rt_sigreturn, (int *)(frame->retcode+1));
                                                                  ^

ERROR: spaces required around that '+' (ctx:VxV)
#441: FILE: linux-user/i386/signal.c:432:
+        __put_user(val16, (uint16_t *)(frame->retcode+5));
                                                      ^

ERROR: do not use C99 // comments
#528: FILE: linux-user/i386/signal.c:519:
+    //          regs->orig_eax = -1;            /* disable syscall checks */

ERROR: braces {} are necessary for all arms of this statement
#558: FILE: linux-user/i386/signal.c:549:
+    if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]

ERROR: space required before the open parenthesis '('
#562: FILE: linux-user/i386/signal.c:553:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#570: FILE: linux-user/i386/signal.c:561:
+    if (restore_sigcontext(env, &frame->sc))
[...]

ERROR: braces {} are necessary for all arms of this statement
#590: FILE: linux-user/i386/signal.c:581:
+    if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]

WARNING: line over 80 characters
#599: FILE: linux-user/i386/signal.c:590:
+    if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe, 
uc.tuc_stack), 0,

total: 16 errors, 2 warnings, 1196 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 17/20: linux-user: move sparc/sparc64 signal.c parts to sparc 
directory...
ERROR: space prohibited before open square bracket '['
#708: FILE: linux-user/sparc/signal.c:83:
+    } si_fpqueue [16];

ERROR: space prohibited between function name and open parenthesis '('
#716: FILE: linux-user/sparc/signal.c:91:
+    abi_ulong           insns[2] __attribute__ ((aligned (8)));

ERROR: trailing whitespace
#747: FILE: linux-user/sparc/signal.c:122:
+static inline abi_ulong get_sigframe(struct target_sigaction *sa, $

ERROR: line over 90 characters
#758: FILE: linux-user/sparc/signal.c:133:
+                && !((target_sigaltstack_used.ss_sp + 
target_sigaltstack_used.ss_size) & 7)) {

WARNING: line over 80 characters
#759: FILE: linux-user/sparc/signal.c:134:
+            sp = target_sigaltstack_used.ss_sp + 
target_sigaltstack_used.ss_size;

ERROR: spaces required around that '=' (ctx:VxV)
#774: FILE: linux-user/sparc/signal.c:149:
+    for (i=0; i < 8; i++) {
           ^

ERROR: spaces required around that '=' (ctx:VxV)
#777: FILE: linux-user/sparc/signal.c:152:
+    for (i=0; i < 8; i++) {
           ^

ERROR: spaces required around that '+' (ctx:VxV)
#778: FILE: linux-user/sparc/signal.c:153:
+        __put_user(env->regwptr[UREG_I0 + i], &si->si_regs.u_regs[i+8]);
                                                                    ^

ERROR: if this code is redundant consider removing it
#784: FILE: linux-user/sparc/signal.c:159:
+#if 0

ERROR: do not use C99 // comments
#812: FILE: linux-user/sparc/signal.c:187:
+    //synchronize_user_stack();

ERROR: if this code is redundant consider removing it
#823: FILE: linux-user/sparc/signal.c:198:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#824: FILE: linux-user/sparc/signal.c:199:
+    if (invalid_frame_pointer(sf, sigframe_size))
[...]

ERROR: do not use C99 // comments
#831: FILE: linux-user/sparc/signal.c:206:
+    //save_fpu_state(regs, &sf->fpu_state);

ERROR: do not use C99 // comments
#832: FILE: linux-user/sparc/signal.c:207:
+    //__put_user(&sf->fpu_state, &sf->fpu_save);

ERROR: braces {} are necessary for all arms of this statement
#845: FILE: linux-user/sparc/signal.c:220:
+    if (err)
[...]

ERROR: braces {} are necessary for all arms of this statement
#875: FILE: linux-user/sparc/signal.c:250:
+        if (err)
[...]

ERROR: do not use C99 // comments
#879: FILE: linux-user/sparc/signal.c:254:
+        // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0]));

ERROR: do not use C99 // comments
#880: FILE: linux-user/sparc/signal.c:255:
+        // tb_flush(env);

ERROR: if this code is redundant consider removing it
#884: FILE: linux-user/sparc/signal.c:259:
+#if 0

ERROR: spaces required around that '=' (ctx:VxV)
#907: FILE: linux-user/sparc/signal.c:282:
+    int err=0, i;
            ^

ERROR: braces {} are necessary for all arms of this statement
#917: FILE: linux-user/sparc/signal.c:292:
+    if (sf_addr & 3)
[...]

ERROR: spaces required around that '=' (ctx:VxV)
#937: FILE: linux-user/sparc/signal.c:312:
+    for (i=0; i < 8; i++) {
           ^

ERROR: spaces required around that '=' (ctx:VxV)
#940: FILE: linux-user/sparc/signal.c:315:
+    for (i=0; i < 8; i++) {
           ^

ERROR: spaces required around that '+' (ctx:VxV)
#941: FILE: linux-user/sparc/signal.c:316:
+        __get_user(env->regwptr[i + UREG_I0], &sf->info.si_regs.u_regs[i+8]);
                                                                         ^

ERROR: space required before the open parenthesis '('
#954: FILE: linux-user/sparc/signal.c:329:
+    for(i = 1; i < TARGET_NSIG_WORDS; i++) {

ERROR: do not use C99 // comments
#1014: FILE: linux-user/sparc/signal.c:389:
+        //uint128_t qregs[16];

ERROR: spaces required around that '+' (ctx:VxV)
#1111: FILE: linux-user/sparc/signal.c:486:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
                               ^

ERROR: spaces required around that '/' (ctx:VxV)
#1130: FILE: linux-user/sparc/signal.c:505:
+                __get_user(env->fpr[i/2].l.lower, src);
                                      ^

ERROR: spaces required around that '/' (ctx:VxV)
#1132: FILE: linux-user/sparc/signal.c:507:
+                __get_user(env->fpr[i/2].l.upper, src);
                                      ^

ERROR: trailing whitespace
#1163: FILE: linux-user/sparc/signal.c:538:
+    $

ERROR: braces {} are necessary for all arms of this statement
#1189: FILE: linux-user/sparc/signal.c:564:
+        if (err)
[...]

ERROR: do not use C99 // comments
#1194: FILE: linux-user/sparc/signal.c:569:
+    //    __put_user(env->tstate, &((*grp)[SPARC_MC_TSTATE]));

ERROR: spaces required around that '+' (ctx:VxV)
#1214: FILE: linux-user/sparc/signal.c:589:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[UREG_I6];
                               ^

ERROR: spaces required around that '/' (ctx:VxV)
#1231: FILE: linux-user/sparc/signal.c:606:
+                __put_user(env->fpr[i/2].l.lower, dst);
                                      ^

ERROR: spaces required around that '/' (ctx:VxV)
#1233: FILE: linux-user/sparc/signal.c:608:
+                __put_user(env->fpr[i/2].l.upper, dst);
                                      ^

ERROR: braces {} are necessary for all arms of this statement
#1241: FILE: linux-user/sparc/signal.c:616:
+    if (err)
[...]

total: 35 errors, 1 warnings, 1244 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 18/20: linux-user: move mips/mips64 signal.c parts to mips 
directory...
ERROR: space prohibited between function name and open parenthesis '('
#203: FILE: linux-user/mips/signal.c:193:
+    if ((ka->sa_flags & TARGET_SA_ONSTACK) && (sas_ss_flags (sp) == 0)) {

ERROR: "foo * bar" should be "foo *bar"
#221: FILE: linux-user/mips/signal.c:211:
+void setup_frame(int sig, struct target_sigaction * ka,

ERROR: space required before the open parenthesis '('
#238: FILE: linux-user/mips/signal.c:228:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: space prohibited after that open square bracket '['
#252: FILE: linux-user/mips/signal.c:242:
+    regs->active_tc.gpr[ 4] = sig;

ERROR: space prohibited after that open square bracket '['
#253: FILE: linux-user/mips/signal.c:243:
+    regs->active_tc.gpr[ 5] = 0;

ERROR: space prohibited after that open square bracket '['
#254: FILE: linux-user/mips/signal.c:244:
+    regs->active_tc.gpr[ 6] = frame_addr + offsetof(struct sigframe, sf_sc);

ERROR: braces {} are necessary for all arms of this statement
#279: FILE: linux-user/mips/signal.c:269:
+    if (!lock_user_struct(VERIFY_READ, frame, frame_addr, 1))
[...]

ERROR: space required before the open parenthesis '('
#282: FILE: linux-user/mips/signal.c:272:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: if this code is redundant consider removing it
#291: FILE: linux-user/mips/signal.c:281:
+#if 0

ERROR: spaces required around that ':' (ctx:ExV)
#299: FILE: linux-user/mips/signal.c:289:
+        :"r" (&regs));
         ^

WARNING: line over 80 characters
#337: FILE: linux-user/mips/signal.c:327:
+    __put_user(target_sigaltstack_used.ss_size, 
&frame->rs_uc.tuc_stack.ss_size);

ERROR: space required before the open parenthesis '('
#343: FILE: linux-user/mips/signal.c:333:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: space prohibited after that open square bracket '['
#357: FILE: linux-user/mips/signal.c:347:
+    env->active_tc.gpr[ 4] = sig;

ERROR: space prohibited after that open square bracket '['
#358: FILE: linux-user/mips/signal.c:348:
+    env->active_tc.gpr[ 5] = frame_addr

ERROR: space prohibited after that open square bracket '['
#360: FILE: linux-user/mips/signal.c:350:
+    env->active_tc.gpr[ 6] = frame_addr

ERROR: "foo * bar" should be "foo *bar"
#422: FILE: linux-user/mips/target_signal.h:31:
+void setup_frame(int sig, struct target_sigaction * ka,

total: 15 errors, 1 warnings, 798 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/20: linux-user: move ppc/ppc64 signal.c parts to ppc 
directory...
ERROR: braces {} are necessary for all arms of this statement
#375: FILE: linux-user/ppc/signal.c:368:
+    if (sig)
[...]

ERROR: braces {} are necessary for all arms of this statement
#454: FILE: linux-user/ppc/signal.c:447:
+    if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 1))
[...]

ERROR: braces {} are necessary for all arms of this statement
#481: FILE: linux-user/ppc/signal.c:474:
+    if (err)
[...]

ERROR: braces {} are necessary for all arms of this statement
#518: FILE: linux-user/ppc/signal.c:511:
+    if (!lock_user_struct(VERIFY_WRITE, rt_sf, rt_sf_addr, 1))
[...]

ERROR: space prohibited between function name and open parenthesis '('
#532: FILE: linux-user/ppc/signal.c:525:
+    __put_user(h2g (&rt_sf->uc.tuc_mcontext),

ERROR: space required before the open parenthesis '('
#535: FILE: linux-user/ppc/signal.c:528:
+    for(i = 0; i < TARGET_NSIG_WORDS; i++) {

ERROR: braces {} are necessary for all arms of this statement
#565: FILE: linux-user/ppc/signal.c:558:
+    if (err)
[...]

ERROR: braces {} are necessary for all arms of this statement
#614: FILE: linux-user/ppc/signal.c:607:
+    if (!lock_user_struct(VERIFY_READ, sc, sc_addr, 1))
[...]

ERROR: braces {} are necessary for all arms of this statement
#627: FILE: linux-user/ppc/signal.c:620:
+    if (!lock_user_struct(VERIFY_READ, sr, sr_addr, 1))
[...]

WARNING: line over 80 characters
#651: FILE: linux-user/ppc/signal.c:644:
+    if (copy_from_user(&set, h2g(ucp) + offsetof(struct target_ucontext, 
tuc_sigmask),

ERROR: space prohibited between function name and open parenthesis '('
#652: FILE: linux-user/ppc/signal.c:645:
+                       sizeof (set)))

ERROR: braces {} are necessary for all arms of this statement
#662: FILE: linux-user/ppc/signal.c:655:
+    if (!lock_user_struct(VERIFY_READ, mcp, mcp_addr, 1))
[...]

ERROR: braces {} are necessary for all arms of this statement
#679: FILE: linux-user/ppc/signal.c:672:
+    if (!lock_user_struct(VERIFY_READ, rt_sf, rt_sf_addr, 1))
[...]

ERROR: braces {} are necessary for all arms of this statement
#682: FILE: linux-user/ppc/signal.c:675:
+    if (do_setcontext(&rt_sf->uc, env, 1))
[...]

total: 13 errors, 1 warnings, 1361 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 20/20: linux-user: define TARGET_ARCH_HAS_SETUP_FRAME...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-devel] [PATCH for 2.13 v3 14/20] linux-user: move hppa signal.c parts to hppa directory, (continued)
- [Qemu-devel] [PATCH for 2.13 v3 14/20] linux-user: move hppa signal.c parts to hppa directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 11/20] linux-user: move alpha signal.c parts to alpha directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 05/20] linux-user: move microblaze signal.c parts to microblaze directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 01/20] linux-user: create a dummy per arch signal.c, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 10/20] linux-user: move m68k signal.c parts to m68k directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 09/20] linux-user: move s390x signal.c parts to s390x directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 03/20] linux-user: move arm signal.c parts to arm directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 18/20] linux-user: move mips/mips64 signal.c parts to mips directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory, Laurent Vivier, 2018/04/11
- [Qemu-devel] [PATCH for 2.13 v3 04/20] linux-user: move sh4 signal.c parts to sh4 directory, Laurent Vivier, 2018/04/11
- Re: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to arch directories, no-reply <=
Prev by Date: Re: [Qemu-devel] [RFC PATCH] migration: discard RAMBlocks of type ram_device
Next by Date: [Qemu-devel] [PATCH for 2.13] linux-user: introduce target_sigsp() and target_save_altstack()
Previous by thread: [Qemu-devel] [PATCH for 2.13 v3 04/20] linux-user: move sh4 signal.c parts to sh4 directory
Next by thread: [Qemu-devel] [PATCH v4 for-2.13 00/13] block/mirror: Add active-sync mirroring
Index(es):
- Date
- Thread