Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

[Peter Maydell]

On 12 April 2018 at 12:53, Dr. David Alan Gilbert <address@hidden> wrote:
> * Peter Maydell (address@hidden) wrote:
>> David suggested on IRC that we would want a flag on the ramblock
>> for "not migratable", because there are other uses for "don't
>> migrate this" than just "is this a ram device".
>
> My original suggestion to your series was with a flag, but I'd forgotten
> about that by the time I'd made the suggestion to Cédric.
> In your case would just adding an extra term to the
> ram_block_is_migratable function work, or do you really need a flag?

I don't see how else you would identify the ram block that needs
to be skipped. Also I think it's just better design to decouple
the decision about "should we migrate this ram block" from the
migration code itself, and push it up to the code layer that knows
it's creating ram blocks that shouldn't be migrated.

thanks
-- PMM