Re: [Qemu-devel] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper

[Vladimir Sementsov-Ogievskiy]

21.03.2018 18:05, Eric Blake wrote:
> On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
> > The helper will be reused for bitmaps namespace.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> >   nbd/server.c | 41 ++++++++++++++++++++++++++++-------------
> >   1 file changed, 28 insertions(+), 13 deletions(-)
>
> > +/* Read len bytes and check matching to the pattern.
> > + * @match is set to true on empty query for _LIST_ and for query 
> > matching the
> > + * @pattern. @match is never set to false.
>
> How about:
>
> Read @len bytes, and set @match to true if they match @pattern, or if 
> @len is 0 and the client is performing _LIST_.  @match is never set to 
> false.

will add, as always, thank you for natural rewording) Hm, I have a 
question: why do you often use double white-space "  " between 
sentences? Is it something meaningful?

> At any rate, the refactoring is sane; and comment touchups are 
> trivial, so
>
> Reviewed-by: Eric Blake <address@hidden>


--
Best regards,
Vladimir