Re: [Qemu-devel] [PATCH v2 15/17] target/riscv: convert to DisasJumpType

[Richard Henderson]

> Cc: Michael Clark <address@hidden>
> Cc: Palmer Dabbelt <address@hidden>
> Cc: Sagar Karandikar <address@hidden>
> Cc: Bastian Koppelmann <address@hidden>
> 
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/riscv/translate.c | 72 
> +++++++++++++++++++-----------------------------
>  1 file changed, 28 insertions(+), 44 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


> @@ -1345,12 +1339,12 @@ static void gen_system(CPURISCVState *env, 
> DisasContext *ctx, uint32_t opc,
>              /* always generates U-level ECALL, fixed in do_interrupt handler 
> */
>              generate_exception(ctx, RISCV_EXCP_U_ECALL);
>              tcg_gen_exit_tb(0); /* no chaining */
> -            ctx->bstate = BS_BRANCH;
> +            ctx->is_jmp = DISAS_NORETURN;
>              break;
>          case 0x1: /* EBREAK */
>              generate_exception(ctx, RISCV_EXCP_BREAKPOINT);
>              tcg_gen_exit_tb(0); /* no chaining */
> -            ctx->bstate = BS_BRANCH;
> +            ctx->is_jmp = DISAS_NORETURN;
>              break;

Not for Emilio, but for the RISCV guys as a follow-up, exit_tb after
generate_exception is dead code -- we have already exited via longjmp.  There
are more than these two instances.


r~