Re: [Qemu-devel] Last call for release-critical fixes for 2.12

[Stefan Weil]

Am 17.04.2018 um 15:50 schrieb Peter Maydell:
> On 17 April 2018 at 14:19, Stefan Weil <address@hidden> wrote:
>> Update po files? That's not a "must fix", but it would be nice to have
>> those files synchronized with ui/gtk.c again.
> Judging by the "POT-Creation-Date" timestamps, we haven't done
> that for a year or so, so there doesn't seem to be a great
> urgency to do it now.
>
> Overall:
>  * I don't really understand why we need to keep doing this;
>    I tried "make -C po update" but all it did was update the
>    date stamp and a bunch of comments in the .po files
>  * If we do need to do this, we need to come up with a
>    process (preferably automatic) that ensures that we do
>    it in a more timely manner than "somebody mentions it
>    on the day we're thinking of tagging the final rc"
>
> Asking me to manually run a magic command I don't understand
> doesn't really work, as you can see from how infrequently
> it's happened.
>
> thanks
> -- PMM

The only visible consequence if it is not done is that developers who
run "make install" (which updates the po files) then have a local code
modification which is in the way if they are working with git. Not many
run "make install", and obviously those who do can handle the situation.
I think that there would be a real problem if people tried to build with
the source on a read only medium.

I wonder whether generating the po files without the line comments would
improve the situation. Currently each added or removed line in ui/gtk.c
changes the line numbers which are part of the comments. If the comments
would not include line numbers, then only relevant changes of message
texts would need an update of the po files. Maybe we should try that for
the next release.

Stefan