[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTA
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check |
Date: |
Thu, 19 Apr 2018 02:21:21 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and
MAINTAINERS check
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
77f2922cd7 checkpatch: reduce MAINTAINERS update message frequency
c5660effcb checkpatch: emit a warning on file add/move/delete
4f224ba569 checkpatch: ignore email headers better
8524202abe checkpatch: check utf-8 content from a commit log when it's missing
from charset
dab42b2f0d checkpatch: add a --strict check for utf-8 in commit logs
=== OUTPUT BEGIN ===
Checking PATCH 1/5: checkpatch: add a --strict check for utf-8 in commit logs...
WARNING: line over 80 characters
#96: FILE: scripts/checkpatch.pl:1420:
+ "8-bit UTF-8 used in possible commit log\n" .
$herecurr);
total: 0 errors, 1 warnings, 67 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: checkpatch: check utf-8 content from a commit log when it's
missing from charset...
Checking PATCH 3/5: checkpatch: ignore email headers better...
Checking PATCH 4/5: checkpatch: emit a warning on file add/move/delete...
WARNING: line over 80 characters
#41: FILE: scripts/checkpatch.pl:1396:
+ ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/
&&
ERROR: line over 90 characters
#45: FILE: scripts/checkpatch.pl:1400:
+ "added, moved or deleted file(s), does MAINTAINERS
need updating?\n" . $herecurr);
total: 1 errors, 1 warnings, 25 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/5: checkpatch: reduce MAINTAINERS update message frequency...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset, (continued)
- [Qemu-devel] [PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset, Stefan Hajnoczi, 2018/04/19
- [Qemu-devel] [PATCH 1/5] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/04/19
- [Qemu-devel] [PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/04/19
- [Qemu-devel] [PATCH 4/5] checkpatch: emit a warning on file add/move/delete, Stefan Hajnoczi, 2018/04/19
- [Qemu-devel] [PATCH 3/5] checkpatch: ignore email headers better, Stefan Hajnoczi, 2018/04/19
- Re: [Qemu-devel] [PATCH 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check,
no-reply <=