Re: [Qemu-devel] [PATCH] riscv: requires libfdt

[Paolo Bonzini]

On 19/04/2018 12:51, KONRAD Frederic wrote:
> When compiling on a machine without libfdt installed the configure script
> should try to get libfdt from the git or should die because otherwise
> CONFIG_LIBFDT is not set and the build process end in an error in the link
> phase.. eg:
> 
> hw/riscv/virt.o: In function `riscv_virt_board_init':
> qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell'
> qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell'
> qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb'
> collect2: error: ld returned 1 exit status
> make[1]: *** [qemu-system-riscv64] Error 1
> make: *** [subdir-riscv64-softmmu] Error 2
> 
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 0a19b03..1587f08 100755
> --- a/configure
> +++ b/configure
> @@ -3732,7 +3732,7 @@ fi
>  fdt_required=no
>  for target in $target_list; do
>    case $target in
> -    
> aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu)
> +    
> aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu|riscv64-softmmu)
>        fdt_required=yes
>      ;;
>    esac
> 

Maybe good for 2.12, even though it would make the final rc and final
release different?

Thanks,

Paolo