[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be |
Date: |
Thu, 19 Apr 2018 19:09:13 -0300 |
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
use of Chardev->be. Also, this CharBackend member is private and is
not supposed to be accessible.
Fix it by removing the inconsistent check.
Reported-by: Marc-André Lureau <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/isa/isa-superio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c
index b95608a003..08afe44731 100644
--- a/hw/isa/isa-superio.c
+++ b/hw/isa/isa-superio.c
@@ -43,7 +43,7 @@ static void isa_superio_realize(DeviceState *dev, Error
**errp)
if (!k->parallel.is_enabled || k->parallel.is_enabled(sio, i)) {
/* FIXME use a qdev chardev prop instead of parallel_hds[] */
chr = parallel_hds[i];
- if (chr == NULL || chr->be) {
+ if (chr == NULL) {
name = g_strdup_printf("discarding-parallel%d", i);
chr = qemu_chr_new(name, "null");
} else {
@@ -83,7 +83,7 @@ static void isa_superio_realize(DeviceState *dev, Error
**errp)
if (!k->serial.is_enabled || k->serial.is_enabled(sio, i)) {
/* FIXME use a qdev chardev prop instead of serial_hds[] */
chr = serial_hds[i];
- if (chr == NULL || chr->be) {
+ if (chr == NULL) {
name = g_strdup_printf("discarding-serial%d", i);
chr = qemu_chr_new(name, "null");
} else {
--
2.17.0
- [Qemu-devel] [PATCH 0/2] hw/superio: Fix inconsistent use of Chardev->be, Philippe Mathieu-Daudé, 2018/04/19
- [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be,
Philippe Mathieu-Daudé <=
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Peter Maydell, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Philippe Mathieu-Daudé, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Peter Maydell, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Philippe Mathieu-Daudé, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Peter Maydell, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Philippe Mathieu-Daudé, 2018/04/20
- Re: [Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be, Peter Maydell, 2018/04/20
[Qemu-devel] [PATCH 2/2] Revert "Revert "mux: fix ctrl-a b again"" again, Philippe Mathieu-Daudé, 2018/04/19