[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for config
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for configure |
Date: |
Fri, 20 Apr 2018 10:08:19 +0800 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, 04/19 14:58, Alex Bennée wrote:
> From: Peter Maydell <address@hidden>
>
> This is a helper function for the configure script. It replies yes,
> sudo or no to inform the user if non-interactive docker support is
> available. We trap the Exception to fail gracefully.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> tests/docker/docker.py | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 1246ba9578..f8267586eb 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -390,6 +390,24 @@ class ImagesCommand(SubCommand):
> def run(self, args, argv):
> return Docker().command("images", argv, args.quiet)
>
> +
> +class ProbeCommand(SubCommand):
> + """Probe if we can run docker automatically"""
> + name = "probe"
> +
> + def run(self, args, argv):
> + try:
> + docker = Docker()
> + if docker._command[0] == "docker":
> + print "yes"
> + elif docker._command[0] == "sudo":
> + print "sudo"
> + except Exception:
> + print "no"
Non-zero exit code is better in 'no' case, but I guess it's not required by
configure. Either way:
Reviewed-by: Fam Zheng <address@hidden>
> +
> + return
> +
> +
> def main():
> parser = argparse.ArgumentParser(description="A Docker helper",
> usage="%s <subcommand> ..." % os.path.basename(sys.argv[0]))
> --
> 2.17.0
>
- Re: [Qemu-devel] [PATCH v2 04/43] configure: move i386_cc to cross_cc_i386, (continued)
- [Qemu-devel] [PATCH v2 06/43] configure: set cross_cc_FOO for host compiler, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for configure, Alex Bennée, 2018/04/19
- Re: [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for configure,
Fam Zheng <=
- [Qemu-devel] [PATCH v2 05/43] configure: allow user to specify --cross-cc-cflags-foo=, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 10/43] docker: allow "cc" command to run in user context, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 14/43] tests/tcg/multiarch: enable additional linux-test tests, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 08/43] docker: Add "cc" subcommand, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 07/43] Makefile: Rename TARGET_DIRS to TARGET_LIST, Alex Bennée, 2018/04/19