[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_ST
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP |
Date: |
Fri, 20 Apr 2018 14:55:05 -0400 |
The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena
changes hflags, which ends up changing the TB flags via
cpu_get_tb_cpu_state). This requires a full lookup (i.e.
with flags) via lookup_and_goto_ptr instead of gen_goto_tb,
since the latter only looks at the PC for in-page goto's. Fix it.
Reported-by: Richard Henderson <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
target/mips/translate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index d8e717d..69137d0 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -20343,7 +20343,8 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
} else {
switch (ctx.bstate) {
case BS_STOP:
- gen_goto_tb(&ctx, 0, ctx.pc);
+ gen_save_pc(ctx.pc);
+ tcg_gen_lookup_and_goto_ptr();
break;
case BS_NONE:
save_cpu_state(&ctx, 0);
--
2.7.4
- [Qemu-devel] [PATCH v3 00/18] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 05/18] target/sparc: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 03/18] target/sparc: convert to DisasJumpType, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 04/18] target/sparc: convert to DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 02/18] target/sh4: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP,
Emilio G. Cota <=
- [Qemu-devel] [PATCH 01/18] translator: merge max_insns into DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 10/18] target/mips: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 14/18] target/openrisc: convert to DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 18/18] target/riscv: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 13/18] target/s390x: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 15/18] target/openrisc: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 09/18] target/mips: use *ctx for DisasContext, Emilio G. Cota, 2018/04/20